qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/3] softfloat: extract softfloat-target.h
Date: Tue, 24 May 2011 08:37:04 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 05/23/2011 11:11 PM, Aurelien Jarno wrote:
Looks ok in principle, but I wonder if we should really create a new
header for that. softfloat-specialize.h is already supposed to contain
the target specific functions, so it's probably a good idea to move them
there instead.

I was wondering about that too... I was thinking of separating _private_ target-specific functions and a public interface that is target-specific just because we go for macros rather than extern variables.

In fact, using const variables is another way to solve the problem, without introducing a new header. I'll probably do that for v2.

Also please note that this will conflict with the patch series I sent
recently about removing softfloat-native (most of the patches have been
acked, I'll send a new series soon).

Yes, no problem.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]