[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not
From: |
Hans de Goede |
Subject: |
[Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not set |
Date: |
Tue, 31 May 2011 11:35:20 +0200 |
Note that "op" also is not set, so before this change these error paths
would feed NULL to perror.
---
usb-linux.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index 672a589..e6c6138 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -373,7 +373,8 @@ static int usb_host_claim_interfaces(USBHostDevice *dev,
int configuration)
i = 0;
dev_descr_len = dev->descr[0];
if (dev_descr_len > dev->descr_len) {
- goto fail;
+ fprintf(stderr, "husb: update iface failed. descr too short\n");
+ return 0;
}
i += dev_descr_len;
@@ -401,7 +402,7 @@ static int usb_host_claim_interfaces(USBHostDevice *dev,
int configuration)
if (i >= dev->descr_len) {
fprintf(stderr,
"husb: update iface failed. no matching configuration\n");
- goto fail;
+ return 0;
}
nb_interfaces = dev->descr[i + 4];
--
1.7.5.1
- [Qemu-devel] [PATCH 00/14] usb: various usb fixes, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 01/14] usb-linux: Set usb_auto_timer to NULL after deleting it, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 02/14] usb-linux: Get speed from sysfs rather then from the connectinfo ioctl, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 04/14] usb-linux: Don't do perror when errno is not set,
Hans de Goede <=
- [Qemu-devel] [PATCH 05/14] usb-linux: Don't call usb_host_close when usb_host_open fails, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 06/14] usb-linux: Ensure devep != 0, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 03/14] usb-linux: Teach about super speed, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 07/14] usb-linux: If opening a device fails remove it from our filter list, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 08/14] usb-linux: Don't try to open the same device twice, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 10/14] usb-linux: Enlarge buffer for descriptors to 8192 bytes, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 11/14] usb-bus: Add knowledge of USB_SPEED_SUPER to usb_speed helper, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 12/14] usb-bus: Don't allow attaching a device to a bus with no free ports, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Hans de Goede, 2011/05/31