[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4][ 5/7] guest agent: add guest agent RPCs/comm
From: |
Andi Kleen |
Subject: |
Re: [Qemu-devel] [PATCH v4][ 5/7] guest agent: add guest agent RPCs/commands |
Date: |
Sat, 04 Jun 2011 13:08:24 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Michael Roth <address@hidden> writes:
> +
> +int64_t qmp_guest_file_open(const char *filename, const char *mode, Error
> **err)
> +{
> + FILE *fh;
> + int fd, ret;
> + int64_t id = -1;
> +
> + if (!logging_enabled()) {
> + error_set(err, QERR_QGA_LOGGING_FAILED);
> + goto out;
> + }
> + slog("guest-file-open called, filename: %s, mode: %s", filename, mode);
> + fh = fopen(filename, mode);
> + if (!fh) {
> + error_set(err, QERR_OPEN_FILE_FAILED, filename);
> + goto out;
> + }
Does this really allow a guest to open any host file ?!?
Have you considered all the security implications of that?
-Andi
--
address@hidden -- Speaking for myself only
- [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v4, Michael Roth, 2011/06/03
- [Qemu-devel] [PATCH v4][ 1/7] guest agent: worker thread class, Michael Roth, 2011/06/03
- [Qemu-devel] [PATCH v4][ 2/7] guest agent: command state class, Michael Roth, 2011/06/03
- [Qemu-devel] [PATCH v4][ 3/7] guest agent: qemu-ga daemon, Michael Roth, 2011/06/03
- [Qemu-devel] [PATCH v4][ 4/7] guest agent: add error class for QERR_QGA_LOGGING_FAILED, Michael Roth, 2011/06/03
- [Qemu-devel] [PATCH v4][ 5/7] guest agent: add guest agent RPCs/commands, Michael Roth, 2011/06/03
- Re: [Qemu-devel] [PATCH v4][ 5/7] guest agent: add guest agent RPCs/commands,
Andi Kleen <=
- [Qemu-devel] [PATCH v4][ 6/7] guest agent: add guest agent commands schema file, Michael Roth, 2011/06/03
- [Qemu-devel] [PATCH v4][ 7/7] guest agent: Makefile, build qemu-ga, Michael Roth, 2011/06/03