[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete |
Date: |
Wed, 13 Jul 2011 12:30:15 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 13, 2011 at 09:51:14AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >+void qxl_render_primary_updated(PCIQXLDevice *qxl, QXLRect *dirty,
> >+ uint32_t num_dirty);
>
> >@@ -65,6 +65,10 @@ struct SimpleSpiceDisplay {
> > int notify;
> > int running;
> >
> >+#if SPICE_INTERFACE_QXL_MINOR>= 1
> >+ QXLRect *dirty_rects;
> >+ uint32_t num_dirty_rects;
> >+#endif
>
> Why do you put this into SimpleSpiceDisplay instead of PCIQXLState?
>
> I also wouldn't #ifdef the struct elements to reduce the #ifdef
> clutter. #ifdefs should only be there in case the code wouldn't
> compile without them.
>
> Additionally you can fill these struct elements in sync mode too and
> have qxl_render_primary_updated pick up the rectangles from the
> struct instead of getting them passed in as arguments, thereby
> reducing the code differences between sync and async mode.
>
ok, will do.
> cheers,
> Gerd
>
- [Qemu-devel] [PATCHv3] qxl-render: split out qxl_render_update_dirty_rectangles, (continued)
- [Qemu-devel] [PATCHv3] qxl-render: split out qxl_render_update_dirty_rectangles, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] spice/qxl: move worker wrappers, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: async io support using new spice api, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: use QXL_REVISION_*, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render: qxl_render_update: nop if \!ssd.running, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort), Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support, Alon Levy, 2011/07/12
- Re: [Qemu-devel] [PATCHv3] async + suspend reworked, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] async + suspend reworked, Gerd Hoffmann, 2011/07/13