[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm |
Date: |
Wed, 13 Jul 2011 09:32:10 -0300 |
On Wed, 13 Jul 2011 12:41:48 +0200
Gerd Hoffmann <address@hidden> wrote:
> On 07/13/11 11:29, Alon Levy wrote:
> > On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote:
> >> On 07/12/11 15:55, Alon Levy wrote:
> >>> Later the save will happen asynchronously on surface_updated callback.
> >>
> >> Hmm. I can see why you are doing that. It makes the file being
> >> written *after* the monitor command finishes though, which I think
> >> we should avoid.
> >
> > I think the simplest thing would be to add a specific cond for this -
> > ppm_save_filename_cond. ok?
>
> Not sure. Luiz, do we have async monitor commands meanwhile?
Not yet, this is a QAPI feature that should land soon, but it's not
available yet.
>
> Background: screendump for qxl vga can take a while as the spice-server
> might have to render everything first ...
>
> cheers,
> Gerd
>
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, (continued)
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Daniel P. Berrange, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Luiz Capitulino, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Alon Levy, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, Daniel P. Berrange, 2011/07/13
[Qemu-devel] [PATCHv3] qxl: add io_port_to_string, Alon Levy, 2011/07/12
[Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass ram->update_area directly to update_area, Alon Levy, 2011/07/12
[Qemu-devel] [PATCHv3] qxl-render: split out qxl_render_update_dirty_rectangles, Alon Levy, 2011/07/12
[Qemu-devel] [PATCHv3] spice/qxl: move worker wrappers, Alon Levy, 2011/07/12