[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/8] SPARC64: fp_disabled checks on stfa/stdf
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/8] SPARC64: fp_disabled checks on stfa/stdfa/stqfa |
Date: |
Thu, 14 Jul 2011 20:56:16 +0300 |
On Thu, Jul 14, 2011 at 1:39 PM, Peter Maydell <address@hidden> wrote:
> On 14 July 2011 10:41, Tsuneo Saito <address@hidden> wrote:
>> stfa/stdfa/stqfa instructions should raise fp_disabled exceptions
>> if %pstate.PEF==0 or %fprs.FEF==0.
>
> Not really related to this patch but I happened to notice it:
> we generate a trap if dc->fpu_enabled is clear. That flag is set with:
> dc->fpu_enabled = cpu_fpu_enabled(env);
> which looks at the CPUState passed into gen_intermediate_code_internal.
>
> I think it should be pulling the fpu-enabled state out of the
> tb->flags instead. Otherwise you'll have problems if you have
> a TB with (1) a trap-if-no-fpu insn (2) a change of the fpu-enabled
> state (3) a load/store that faults.
I applied a patch to fix this and similar bug with AM bit.
- [Qemu-devel] [PATCH v2 0/8] SPARC64: Implement sparcv9 ldfa/stfa instructions, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 1/8] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 2/8] SPARC64: fp_disabled checks on ldfa/lddfa/ldqfa, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 3/8] SPARC64: Implement stfa/stdfa/stqfa instrcutions properly, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 4/8] SPARC64: fp_disabled checks on stfa/stdfa/stqfa, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 6/8] SPARC64: Add UA2007 ASI_BLK_AIU[PS]L? ASIs for stfa, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 5/8] SPARC64: Add UA2007 ASI_BLK_AIU[PS]L? ASIs for ldfa, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 7/8] SPARC64: Add JPS1 ASI_BLK_AIU[PS]L ASIs for ldfa and stfa, Tsuneo Saito, 2011/07/14
- [Qemu-devel] [PATCH v2 8/8] SPARC64: C99 comment fix for block-transfer ASIs, Tsuneo Saito, 2011/07/14
- Re: [Qemu-devel] [PATCH v2 0/8] SPARC64: Implement sparcv9 ldfa/stfa instructions, Blue Swirl, 2011/07/14