[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/8] configure: Avoid duplicate flags when calling c
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 5/8] configure: Avoid duplicate flags when calling compile_prog |
Date: |
Fri, 9 Sep 2011 10:24:12 +0100 |
From: Stefan Weil <address@hidden>
This patch removes redundant shell code and cleans it a little bit.
Shell macro compile_prog takes two arguments:
local_cflags and local ldflags.
$QEMU_CFLAGS is added automatically to the cflags, so there is no need
to pass it as an argument.
It is also unnecessary to pass -Werror twice.
$flag is a compiler warning option, so it should be in local_cflags
instead of local_ldflags.
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index f808f48..348f36a 100755
--- a/configure
+++ b/configure
@@ -1070,7 +1070,7 @@ cat > $TMPC << EOF
int main(void) { return 0; }
EOF
for flag in $gcc_flags; do
- if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
+ if compile_prog "$flag -Werror" "" ; then
QEMU_CFLAGS="$QEMU_CFLAGS $flag"
fi
done
--
1.7.5.4
- [Qemu-devel] [PULL 0/8] Trivial patches for September 3 to 9 2011, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 2/8] configure: Remove relicts from --enable-io-thread, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 4/8] qemu-options: Improve help texts for options which depend on configure, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 8/8] Fix include statements for qemu-common.h, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 3/8] docs: Fix qdev-device-use.txt typo in -chardev serial, path=COM<NUM>, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 7/8] virtio-9p: Fix syntax error in debug code, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 1/8] Fix comment (install patch -> install path), Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 6/8] SPARC: Trivial patch to clean up npc monitor output, Stefan Hajnoczi, 2011/09/09
- [Qemu-devel] [PATCH 5/8] configure: Avoid duplicate flags when calling compile_prog,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PULL 0/8] Trivial patches for September 3 to 9 2011, Anthony Liguori, 2011/09/09