[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly |
Date: |
Mon, 17 Oct 2011 16:10:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 |
Am 17.10.2011 16:04, schrieb Paolo Bonzini:
> On 10/17/2011 04:05 PM, Kevin Wolf wrote:
>>>> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
>>>> index 347c38d..10f161f 100644
>>>> --- a/hw/ide/atapi.c
>>>> +++ b/hw/ide/atapi.c
>>>> @@ -731,6 +731,8 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf)
>>>> buf[7] = 0;
>>>>
>>>> /* Fill with CDROM audio volume */
>>>> + buf[8] = 0x0e;
>>
>> 0x0e would be more readable if it was written as MODE_PAGE_AUDIO_CTL.
>>
>>>> + buf[9] = 0x0e;
>>
>> And this is really the length. But I'm not sure if writing it as 24 - 10
>> would help a lot.
>
> Yes, the coincidence is ugly.
Maybe we should define structs for the mode pages so that you have real
names instead of just offsets into the output buffer?
>> Of course the same is true for the other pages, so it could be done for
>> all of them on top. Or maybe you actually have included it later in the
>> series?
>
> Only for SCSI. I can queue it as a cleanup for ATAPI.
That would be good.
Kevin
[Qemu-devel] [PATCH 03/35] atapi: move GESN definitions to scsi-defs.h, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 02/35] atapi/scsi: unify definitions for MMC, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 06/35] scsi-disk: report media changed via unit attention sense codes, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 05/35] scsi: notify the device when unit attention is reported, Paolo Bonzini, 2011/10/13
[Qemu-devel] [PATCH 09/35] atapi/scsi-disk: make mode page values coherent between the two, Paolo Bonzini, 2011/10/13