qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly
Date: Mon, 17 Oct 2011 16:22:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0

On 10/17/2011 04:10 PM, Kevin Wolf wrote:
>  Yes, the coincidence is ugly.

Maybe we should define structs for the mode pages so that you have real
names instead of just offsets into the output buffer?

Yeah, it would be nice to have a common place for all the structs defined by the SCSI spec (also the GET CONFIGURATION data is ugly).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]