Re: [Qemu-devel] [PATCH] target-xtensa: raise an exception for invalid and reserved opcodes

[Peter Maydell]

On 25 October 2011 17:44, Max Filippov <address@hidden> wrote:
> This includes opcodes from disabled features and those marked reserved in the 
> ISA.
>
> Signed-off-by: Max Filippov <address@hidden>
> ---
>  target-xtensa/translate.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c
> index 1688bb2..792eff1 100644
> --- a/target-xtensa/translate.c
> +++ b/target-xtensa/translate.c
> @@ -2378,6 +2378,7 @@ static void disas_xtensa_insn(DisasContext *dc)
>
>  invalid_opcode:
>     qemu_log("INVALID(pc = %08x)\n", dc->pc);
> +    gen_exception_cause(dc, ILLEGAL_INSTRUCTION_CAUSE);
>     dc->pc = dc->next_pc;
>  #undef HAS_OPTION
>  }

Don't you need to do something to end the TB as well?
gen_exception_cause() doesn't seem to do it for you.

-- PMM