[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-xtensa: raise an exception for invalid a
From: |
Max Filippov |
Subject: |
Re: [Qemu-devel] [PATCH] target-xtensa: raise an exception for invalid and reserved opcodes |
Date: |
Tue, 25 Oct 2011 21:24:58 +0400 |
User-agent: |
KMail/1.13.7 (Linux/2.6.40.6-0.fc15.x86_64; KDE/4.6.5; x86_64; ; ) |
> > This includes opcodes from disabled features and those marked reserved in
> > the ISA.
> >
> > Signed-off-by: Max Filippov <address@hidden>
> > ---
> > target-xtensa/translate.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c
> > index 1688bb2..792eff1 100644
> > --- a/target-xtensa/translate.c
> > +++ b/target-xtensa/translate.c
> > @@ -2378,6 +2378,7 @@ static void disas_xtensa_insn(DisasContext *dc)
> >
> > invalid_opcode:
> > qemu_log("INVALID(pc = %08x)\n", dc->pc);
> > + gen_exception_cause(dc, ILLEGAL_INSTRUCTION_CAUSE);
> > dc->pc = dc->next_pc;
> > #undef HAS_OPTION
> > }
>
> Don't you need to do something to end the TB as well?
> gen_exception_cause() doesn't seem to do it for you.
Do you mean that I have to end the TB on every instruction that will definitely
raise an exception?
Or on every instruction that potentially raises an exception?
I didn't do any of the above anywhere.
Thanks.
-- Max