qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflec


From: Benoît Canet
Subject: Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.
Date: Wed, 9 Nov 2011 14:51:37 +0100


I assume ELF_HWCAP is being used in architecture-independent code? Or
would it be feasible to replace all occurrences with the function call?

Many architecture in elfloader.c hardcode ELF_HWCAP before putting into the AT_HWCAP elf field which is used by glibc to guess the cpu capabilities.
I don't feel it so arch independant.
 
I'm wondering if this translation table were better placed in
target-arm/helper.c where we fiddle with the features in the first
place. We could loop through all features here and call a function that
returns the hwcap or 0 and |= it. Me and others will be adding new
features and we'll risk adapting this here.

I modeled this patch by looking at PPC behavior. However I can rewrite it if needed but pcc will need a rewrite too.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]