[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 1/6] Add xgmac ethernet model
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v8 1/6] Add xgmac ethernet model |
Date: |
Fri, 13 Jan 2012 23:27:35 +0000 |
On 11 January 2012 15:26, Mark Langsdorf <address@hidden> wrote:
> This adds very basic support for XG-mac ethernet core from Synopsis and
> others.
> +typedef struct rxtx_stats {
> + uint64_t rx_bytes;
> + uint64_t tx_bytes;
> +
> + uint64_t rx;
> + uint64_t rx_bcast;
> + uint64_t rx_mcast;
> +} rxtx_stats;
Anthony pointed out to me on IRC today the bit of CODING_STYLE that
mandates CamelCase for struct typedef names.
Sorry to bring up coding style issues at this point in the review
process, but can I get you to go through and camelcase the struct
typenames in this patch series?
thanks
-- PMM
[Qemu-devel] [PATCH v8 0/6] arm: add support for Calxeda Highbank SoC, Mark Langsdorf, 2012/01/11
[Qemu-devel] [PATCH v8 5/6] arm: SoC model for Calxeda Highbank, Mark Langsdorf, 2012/01/11
Re: [Qemu-devel] [PATCH v8 5/6] arm: SoC model for Calxeda Highbank, Peter Maydell, 2012/01/11
[Qemu-devel] [PATCH v8 6/6] arm: Remove incorrect comment in arm_timer, Mark Langsdorf, 2012/01/11
[Qemu-devel] [PATCH v8 2/6] arm: make the number of GIC interrupts configurable, Mark Langsdorf, 2012/01/11
Re: [Qemu-devel] [PATCH v8 2/6] arm: make the number of GIC interrupts configurable, Andreas Färber, 2012/01/11
Re: [Qemu-devel] [PATCH v8 2/6] arm: make the number of GIC interrupts configurable, Peter Maydell, 2012/01/11
[Qemu-devel] [PATCH v9 0/6] arm: add support for Calxeda Highbank SoC, Mark Langsdorf, 2012/01/11