|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check |
Date: | Tue, 07 Feb 2012 09:24:30 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 |
On 02/07/2012 08:09 AM, Markus Armbruster wrote:
Cleaned up silently in commit aad04cd0, but that just got reverted. Re-apply this part. Signed-off-by: Markus Armbruster<address@hidden>
Reviewed-by: Anthony Liguori <address@hidden> Regards, Anthony Liguori
--- qemu-char.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index c25863a..bb9e3f5 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1226,10 +1226,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) } tty_serial_init(fd, 115200, 'N', 8, 1); chr = qemu_chr_open_fd(fd, fd); - if (!chr) { - close(fd); - return NULL; - } chr->chr_ioctl = tty_serial_ioctl; chr->chr_close = qemu_chr_close_tty; return chr;
[Prev in Thread] | Current Thread | [Next in Thread] |