qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v3 15/21] target-arm: Store VFP FPSID regist


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH RFC v3 15/21] target-arm: Store VFP FPSID register in ARMCPUClass
Date: Tue, 7 Feb 2012 17:44:24 +0000

On 3 February 2012 02:59, Andreas Färber <address@hidden> wrote:
> @@ -375,6 +383,7 @@ static const ARMCPUInfo arm_cpus[] = {
>             0x00111142, 0, 0, 0
>         },
>         .cp15_c1_sys = 0x00c50078,
> +        .vfp_fpsid = 0x41034000, /* Guess */
>         .features = ARM_FEATURE(V7) |
>                     ARM_FEATURE(VFP3) |
>                     ARM_FEATURE(VFP_FP16) |

> @@ -55,7 +45,6 @@ static void cpu_reset_model_id(CPUARMState *env, uint32_t 
> id)
>         env->cp15.c0_ccsid[2] = 0xf0000000; /* No L2 icache. */
>         break;
>     case ARM_CPUID_CORTEXA9:
> -        env->vfp.xregs[ARM_VFP_FPSID] = 0x41034000; /* Guess */
>         env->vfp.xregs[ARM_VFP_MVFR0] = 0x11110222;
>         env->vfp.xregs[ARM_VFP_MVFR1] = 0x01111111;
>         env->cp15.c0_clid = (1 << 27) | (1 << 24) | 3;

Incidentally, this guess for FPSID is wrong -- it should be 0x41033090 for
the r0p0 we're claiming to model (later revs the bottom nibble is bumped).
I'll send a patch...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]