Re: [Qemu-devel] Restore consistent formatting

[Andreas Färber]

Am 08.02.2012 16:04, schrieb malc:
> On Wed, 8 Feb 2012, Andreas F?rber wrote:
> 
>> Arbitrarily reformatting your files is not okay. If you want a different
>> formatting, you need to fix checkpatch.pl first to not error on that
>> formatting in your files.
> 
> It was always formatter like this (internally consistent), then others
> added code which made it not so.

That's not the point. We use the checkpatch.pl script to check the
formatting of patches, we tell contributors to run it. If you want your
files to have an additional space then _you_ would have to change the
script to not error on that formatting in certain files or else your
formatting changes will get reverted again in the parts other people touch.

Right now you silently caused a needless conflict with other people's
patches, including device_init() -> type_init().

That's a really great way to say "I'm back" after lots of 'mail
receiving disabled' messages...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg