qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files
Date: Sat, 18 Feb 2012 08:18:38 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 02/18/2012 04:56 AM, Stefan Weil wrote:
Am 18.02.2012 10:13, schrieb Blue Swirl:
On Fri, Feb 17, 2012 at 15:26, Anthony Liguori <address@hidden> wrote:
Well this was what I was getting at in my previous comments. If we just
need to reindent < 10 files with a few random changes here and there, then
maybe that isn't so bad.

But if we have to touch every single file in the tree in a significant way,
then no way is it justified.

One way to handle this is gradual reformatting, every time when code
is touched, only changes towards common CODING_STYLE are allowed.
Small, contained reformatting patches should be also allowed, for
example to adjust brace style in one file a time or to remove spaces
at the end of line.

I'd appreciate it very much if we could remove spaces at line endings
for all non binary files as soon as possible.

Why?

I really can't understand this.  It's not visible so it does no harm.

Regards,

Anthony Liguori



reply via email to

[Prev in Thread] Current Thread [Next in Thread]