[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots |
Date: |
Thu, 01 Mar 2012 19:13:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/01/2012 07:08 PM, Eric Blake wrote:
> On 03/01/2012 10:03 AM, Avi Kivity wrote:
> >>>
> >>> - ram = memory_region_get_ram_ptr(mr) + section->offset_within_region;
> >>> + ram = memory_region_get_ram_ptr(mr) + section->offset_within_region
> >>> + delta;
> >>
> >> Am I crazy, or does this look wrong?
> >
> > Could be both. Why do you thing it is wrong?
>
> Line wrapping makes it look like we are adding two lines, one line
> ending in 'section->offset_within_region', and the next line starting
> with 'delta;', which is a syntax error.
>
> But without line wrapping, we are adding just one line with
> 'offset_within_region + delta;' at the end of that line.
>
Ah, of course. I just copy/pasted this into thunderbird, this is not a
proper patch but a pull request. Sorry about the confusion.
Bobby: so it does indeed look wrong. This says nothing about your
sanity though, for that consult a qualified professional instead of
asking on the mailing list.
--
error compiling committee.c: too many arguments to function