[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris |
Date: |
Tue, 27 Mar 2012 17:08:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-03-27 17:01, Paolo Bonzini wrote:
> Il 24/03/2012 17:26, Lee Essen ha scritto:
>> Dynticks was limited to linux. This patch adds Solaris support
>> and ensures a CLOCK_HIGHRES clock is used which is the optimal
>> setup for Solaris systems.
>
> Looks good, but I would prefer if you tested for timer_create in
> configure and use #ifdef CONFIG_RT_TIMER instead.
>
>> +#if defined(__sun__)
>> + if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) {
>> +#else
>> if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) {
>> +#endif
>
> This should be #ifdef CLOCK_HIGHRES.
Are we sure about this is and will remain equivalent and correct?
Also, I found some man page that says CLOCK_HIGHRES is non-adjustable
while CLOCK_REALTIME is. That should make a difference in QEMU.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
[Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris, Lee Essen, 2012/03/24
[Qemu-devel] [PATCH 4/4] qga/channel-posix: provide Solaris alternative to O_ASYNC, Lee Essen, 2012/03/24
Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris, Stefan Hajnoczi, 2012/03/27