Re: [Qemu-devel] [PATCH 3/9] Print out progress when checking compiler flags

[Peter Maydell]

On 2 April 2012 11:50, Daniel P. Berrange <address@hidden> wrote:
> From: "Daniel P. Berrange" <address@hidden>
>
> Normal practice for autoconf style scripts is to print out
> progress. The QEMU configure script is getting increasingly
> slow & has no progress feedback. Print out the progress of
> checking each compiler flag
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  configure |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 64ab4dc..44b28c8 100755
> --- a/configure
> +++ b/configure
> @@ -1170,8 +1170,12 @@ int main(void) { return 0; }
>  EOF
>  warning_flags=
>  for flag in $gcc_flags; do
> +    echo -n "checking if $cc supports $flag... "
>     if compile_prog "-Werror $warning_flags $flag" "" ; then
>        warning_flags="$warning_flags $flag"
> +       echo "yes"
> +    else
> +       echo "no"
>     fi
>  done
>  QEMU_CFLAGS="$QEMU_CFLAGS $warning_flags"

If we're going to do this we should do it consistently,
ie add messages for all tests, not just this one.
(Bonus points for also adding messages to config.log so you
can see which test compiles correspond to which feature tests.)

(Also, "echo -n" isn't portable; we use printf where we don't
want the trailing newline.)

-- PMM