qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 13/36] vmstate: port ppc cpu


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 13/36] vmstate: port ppc cpu
Date: Wed, 11 Apr 2012 12:18:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux)

Peter Maydell <address@hidden> wrote:
> On 19 March 2012 22:57, Juan Quintela <address@hidden> wrote:
>> +    /* Fields needed as intermediate for vmstate */
>> +    target_ulong sdr1_vmstate;
>
> Personally I prefer how alpha handles this for fpcr rather than
> clogging up the CPUState with an intermediate field. (possibly
> with some macro assist so it's a little less longwinded)

Problem with this kind of changes is that once that we change the
format, we need to go through all this special cases to use the new
format.  With this solution, we can change the format without going
through so many places.

As usual, it is a compromise, we need to choose the less worse
solution.

Later, Juan.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]