Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

[Andreas Färber]

Am 12.04.2012 16:59, schrieb Paolo Bonzini:
> Il 12/04/2012 16:47, Anthony Liguori ha scritto:
>>
>>> Wrap setting of Object::realized property, error reporting and exit(1)
>>> into a helper function. It is the equivalent of qdev_init_nofail().
>>
>> I don't like this.
>>
>> If for no reason other than, a much more specific justification is
>> needed for this.  I absolutely don't want to repeat the error handling
>> mistakes of qdev.  I would rather we refactor all of the users of
>> qdev_init_nofail() to propagate errors.
> 
> I agree about this in general, but for a different reason.  There should be
> only one call to object_realize_nofail, in vl.c, which might as well be
> inlined---I'll include it in my series.  All calls to qdev_init_nofail
> and qdev_init should disappear from boards that are properly converted
> to QOM.

We had talked about this on IRC and found that it won't work for
selecting the type of an object.

I can work around it in the sh4 case but the problem stays.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg