[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/16] hw/exynos4210_combiner.c: Drop excessive read
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 03/16] hw/exynos4210_combiner.c: Drop excessive read/write access check. |
Date: |
Fri, 13 Apr 2012 14:04:48 +0100 |
From: Evgeny Voevodin <address@hidden>
Access to reserved area at offset higher than 0x3c is allowed in
External Combiner. Samsung Galaxy Kernel implements this. So, drop
excessive checks in read/write functions.
Signed-off-by: Evgeny Voevodin <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/exynos4210_combiner.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c
index 6110c19..80af22c 100644
--- a/hw/exynos4210_combiner.c
+++ b/hw/exynos4210_combiner.c
@@ -184,11 +184,6 @@ exynos4210_combiner_read(void *opaque, target_phys_addr_t
offset, unsigned size)
uint32_t reg_n; /* Register number inside the quad */
uint32_t val;
- if (s->external && (offset > 0x3c && offset != 0x100)) {
- hw_error("exynos4210.combiner: unallowed read access at offset 0x"
- TARGET_FMT_plx "\n", offset);
- }
-
req_quad_base_n = offset >> 4;
grp_quad_base_n = req_quad_base_n << 2;
reg_n = (offset - (req_quad_base_n << 4)) >> 2;
@@ -281,11 +276,6 @@ static void exynos4210_combiner_write(void *opaque,
target_phys_addr_t offset,
uint32_t grp_quad_base_n; /* Base of group quad */
uint32_t reg_n; /* Register number inside the quad */
- if (s->external && (offset > 0x3c && offset != 0x100)) {
- hw_error("exynos4210.combiner: unallowed write access at offset 0x"
- TARGET_FMT_plx "\n", offset);
- }
-
req_quad_base_n = offset >> 4;
grp_quad_base_n = req_quad_base_n << 2;
reg_n = (offset - (req_quad_base_n << 4)) >> 2;
--
1.7.1
- [Qemu-devel] [PULL 00/16] arm-devs queue, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 15/16] hw/arm_gic: gic_set_pending_private() is NVIC only, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 13/16] hw/arm_gic: Make gic_reset a sysbus reset function, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 01/16] Fix bit test in Exynos4210 UART emulation to use & instead of &&, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 08/16] hw/a15mpcore: switch to using sysbus GIC, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 12/16] hw/arm11mpcore: Convert to using sysbus GIC device, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 11/16] hw/exynos4210_gic: Convert to using sysbus GIC, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 04/16] hw/arm_gic: Move NCPU definition to arm_gic.c, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 10/16] hw/realview_gic: switch to sysbus GIC, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 09/16] hw/a9mpcore: Switch to using sysbus GIC, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 03/16] hw/exynos4210_combiner.c: Drop excessive read/write access check.,
Peter Maydell <=
- [Qemu-devel] [PATCH 06/16] hw/arm_gic: Expose PPI inputs as gpio inputs, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 02/16] ARM: Exynos4210: Drop gic_cpu_write() after initialization., Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 05/16] hw/arm_gic: Move gic_get_current_cpu into arm_gic.c, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 14/16] hw/arm_gic: Use NVIC instead of LEGACY_INCLUDED_GIC define, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 07/16] hw/arm_gic: Make the GIC its own sysbus device, Peter Maydell, 2012/04/13
- [Qemu-devel] [PATCH 16/16] hw/arm_gic: Remove stray hardcoded tab, Peter Maydell, 2012/04/13
- Re: [Qemu-devel] [PULL 00/16] arm-devs queue, Blue Swirl, 2012/04/14