[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function |
Date: |
Wed, 18 Apr 2012 13:53:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/18/2012 11:45 AM, Anthony Liguori wrote:
>>
>>> I thought I had previously asked for a monitor command to negotiate
>>> extensions for migration?
>>
>> I think it is in another patch.
>
> So I think we also need:
>
> { 'command': 'set-migration-capabilities',
> 'data': { 'enable': ['MigrationCapability'] }
>
> Then a management tool just needs to:
>
> caps_from_src = query-migration-capabilities(src_qmp_session)
> caps_from_dst = query-migration-capabilities(dst_qmp_session)
>
> common_caps = intersection(caps_from_src, caps_from_dst)
>
> set-migration-capabilities(src_qmp_session, common_caps);
> set-migration-capabilities(dst_qmp_session, common_caps);
Indeed, this is the most extensible solution. Libvirt only needs to
learn how to drive feature negotiation once, and all future additions of
new migration features will automatically fit into this framework,
without having to modify libvirt further.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v9 03/10] Add save_block_hdr function, Orit Wasserman, 2012/04/11
[Qemu-devel] [PATCH v9 04/10] Add host_from_stream_offset_versioned function, Orit Wasserman, 2012/04/11
[Qemu-devel] [PATCH v9 05/10] Add MigrationParams structure, Orit Wasserman, 2012/04/11
[Qemu-devel] [PATCH v9 06/10] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/04/11