Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification

[Michael S. Tsirkin]

On Tue, Apr 24, 2012 at 04:03:16PM +0200, Paolo Bonzini wrote:
> Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto:
> > @@ -694,7 +698,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue 
> > *vq)
> >      uint16_t old, new;
> >      bool v;
> >      /* We need to expose used array entries before checking used event. */
> > -    mb();
> > +    smp_mb();
> 
> This mb() is not in upstream QEMU, only in qemu-kvm.
> 
> Paolo

Actually patch 1/3 adds this by mistake.
I tested all 3 together so missed this but it would break
bisect. Will fix, thanks.