Re: [Qemu-devel] [PATCH v2 4/6] block: add 'speed' optional parameter to block-stream

[Kevin Wolf]

Am 24.04.2012 15:53, schrieb Stefan Hajnoczi:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index d56fcb6..b1e349f 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1571,15 +1571,19 @@
>  #
>  # @base:   #optional the common backing file name
>  #
> +# @speed:  #optional the maximum speed, in bytes per second

Should mention that 0 means unlimited and is the default if the argument
is not specified.

That an explicit 0 (rather than leaving the argument out) is possible is
actually important for HMP, because there it's the only way to have a
base image, but no speed limit.

> +#
>  # Returns: Nothing on success
>  #          If streaming is already active on this device, DeviceInUse
>  #          If @device does not exist, DeviceNotFound
>  #          If image streaming is not supported by this device, NotSupported
>  #          If @base does not exist, BaseNotFound
> +#          If @speed is invalid, BlockJobSpeedInvalid
>  #
>  # Since: 1.1
>  ##
> -{ 'command': 'block-stream', 'data': { 'device': 'str', '*base': 'str' } }
> +{ 'command': 'block-stream', 'data': { 'device': 'str', '*base': 'str',
> +                                       '*speed': 'int' } }

Kevin