Re: [Qemu-devel] [PATCH 00/32] target-arm: refactor copro register implementation

[Peter Maydell]

On 15 April 2012 14:45, Peter Maydell <address@hidden> wrote:
> This patchseries refactors the target-arm handling of coprocessor
> registers so that you define each register with a struct (and
> possibly some read/write/reset functions), rather than having
> huge nested switch statements in get_cp15()/set_cp15().
>
> My main aim here was to get rid of the unmaintainable switch
> statements. The series also removes all the "behaviour depends
> on value of main ID register" code by a combination of defining
> implementation-specific cp15 regs in the implementation subclass
> instance init functions, and some extra feature bits.
>
> As well as get/set_cp15, we also can remove the rather limited
> existing effort at "define a cp register" used by the pxa2xx
> boards, and the framework has 64 bit register support which should
> provide a nice clean base to implement LPAE registers.
>
> Patch 1 defines all the new infrastructure/framework, while leaving
> the old functions in place. The remaining patches convert small
> subsets of the cp registers, until everything has moved over and
> the old functions can be deleted.

...so is anybody interested in reviewing this series? I'd like
to have some feedback on at least the general shape of it and
whether the patch 1 infrastructure is OK.
(There are a few nits I've noticed myself so there will be
a v2 at some point.)

thanks
-- PMM