qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Posting a patch?


From: Erik Rull
Subject: Re: [Qemu-devel] Posting a patch?
Date: Mon, 14 May 2012 23:29:45 +0200
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120429 Firefox/12.0 SeaMonkey/2.9.1

Stefan Weil wrote:
Am 14.05.2012 23:10, schrieb Erik Rull:
Eric Blake wrote:
On 05/14/2012 02:58 PM, Anthony Liguori wrote:
You can also do:

git send-email address@hidden HEAD~1

Which avoids any clutter.

I also like to do:

git config address@hidden

so I don't have to remember to use --to every time.

'git send-email --cover-letter' gives a nicer cover letter than 'git
send-email --compose'; it really bothers me that 'git send-email --help'
fails to mention that send-email also understands all options of
format-patch.


Thanks for your help. I need to figure out first, why git detects other
changes than mine for posting despite a git checkout master, git pull,
git reset --hard and make distclean.
(See previous email)

Best regards,

Erik


Hi Erik,

I read your previous mail.

"git diff" shows the un-committed changes in your local git repository.
"git format-patch" formats the latest changes in your local git repository.

If you don't commit your own change to your local git repository,
"git format-patch" will format the latest changes from someone else.

As long as "git diff" shows your changes, there is no use to run "git
format-patch".

Regards,

Stefan W.



Thanks a lot!
There is still some improvement possible in my git knowledge :-)

I just handled to post the first patch, but my sendmail is not yet configured for outgoing emails ;-)

So this is my next task...
But meanwhile I will just post it using my windows mail client.

Best regards,

Erik



reply via email to

[Prev in Thread] Current Thread [Next in Thread]