Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

[Gerd Hoffmann]

On 05/22/12 17:29, Alon Levy wrote:
> We can't initialize QXLDevSurfaceCreate field by field because it has a
> pa hole, and so 4 bytes remain uninitialized when building on x86-64, so
> just memset.

So you get valgrind warnings for the hole?  why?  nobody should ever
access the hole, so the missing initialization should not hurt in theory ...

> Signed-off-by: Alon Levy <address@hidden>
> ---
>  ui/spice-display.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ui/spice-display.c b/ui/spice-display.c
> index 5418eb3..3e8f0b3 100644
> --- a/ui/spice-display.c
> +++ b/ui/spice-display.c
> @@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay 
> *ssd)
>  {
>      QXLDevSurfaceCreate surface;
>  
> +    memset(&surface, 0, sizeof(surface));
> +
>      dprint(1, "%s: %dx%d\n", __FUNCTION__,
>             ds_get_width(ssd->ds), ds_get_height(ssd->ds));
>