qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netde


From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing
Date: Wed, 06 Jun 2012 15:03:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120422 Thunderbird/10.0.4

On 06/05/12 23:13, Paolo Bonzini wrote:

> There is one small mistake that needs to be addressed in a v2, so it
> would be great if you could use the int*_t visitors to avoid
> complicating the code with range checks.

OK so this is what I see:

(a) add < 0 checks to <http://patchwork.ozlabs.org/patch/150427/> and
    include it in the series,
(b) make all Netdev integer types as strict as possible, remove
    superfluous checks,
(c) render NetLegacy::name optional.

How do I lay out (a)? Should I include the patch verbatim first (with
proper From: and Signed-off-by: lines) and then modify it in a small
followup, or squash those two and... what? :)

Thanks,
Laszlo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]