[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netde
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing |
Date: |
Wed, 06 Jun 2012 15:31:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 06.06.2012 15:03, schrieb Laszlo Ersek:
> On 06/05/12 23:13, Paolo Bonzini wrote:
>
>> There is one small mistake that needs to be addressed in a v2, so it
>> would be great if you could use the int*_t visitors to avoid
>> complicating the code with range checks.
>
> OK so this is what I see:
>
> (a) add < 0 checks to <http://patchwork.ozlabs.org/patch/150427/> and
> include it in the series,
> (b) make all Netdev integer types as strict as possible, remove
> superfluous checks,
> (c) render NetLegacy::name optional.
>
> How do I lay out (a)? Should I include the patch verbatim first (with
> proper From: and Signed-off-by: lines) and then modify it in a small
> followup, or squash those two and... what? :)
I am missing context here. The referenced patch is on qom-next already
and will thus be in my upcoming PULL (today or tomorrow) unless someone
comments on that patch, cc'ing me, that there's an error. Feel free to
cherry-pick from there but do not squash into random series please.
I don't understand what < 0 checks you are talking about, lacking time
to go through this QIDL patch series ATM.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Paolo Bonzini, 2012/06/05
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Laszlo Ersek, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Michael Roth, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Laszlo Ersek, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Michael Roth, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Michael Roth, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Paolo Bonzini, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Laszlo Ersek, 2012/06/06
- Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing, Laszlo Ersek, 2012/06/06