[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Prop-ptr and Xilinx.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] Prop-ptr and Xilinx. |
Date: |
Wed, 13 Jun 2012 08:38:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Il 13/06/2012 08:21, Peter Crosthwaite ha scritto:
>
> Im testing your revisions the the xilinx ip around getting rid of the
> pointer props (your prop-ptr branch on your github).
>
> First up theres a typo in the machine model stuff, heres the fix:
>
> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
> index 37866f4..e718183 100644
> --- a/hw/petalogix_ml605_mmu.c
> +++ b/hw/petalogix_ml605_mmu.c
> @@ -126,7 +126,7 @@ petalogix_ml605_init(ram_addr_t ram_size,
> xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
>
> /* axi ethernet and dma initialization. */
> - DeviceState *dma = qdev_create(NULL, "xilinx-axidma");
> + DeviceState *dma = qdev_create(NULL, "xilinx,axidma");
> DeviceState *eth0;
>
> eth0 = xilinx_axiethernet_create(&nd_table[0], XILINX_AXIDMA_PEER(dma),
>
> I corrected this and ran it but SIGABRT'ed on some assertion in the
> qom framework:
It's quite possible that interfaces are borked, since we have no unit
tests and no user. :/
Paolo