[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item |
Date: |
Thu, 14 Jun 2012 12:16:28 -0600 |
User-agent: |
StGIT/0.14.3 |
MSIX, like PCI, is little endian. Specifying native is wrong here,
but we need to check the rest of the file to determine if it's
as simple as flipping this macro.
Signed-off-by: Alex Williamson <address@hidden>
---
hw/msix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/msix.c b/hw/msix.c
index 50885ac..87d316a 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque,
target_phys_addr_t addr,
static const MemoryRegionOps msix_mmio_ops = {
.read = msix_mmio_read,
.write = msix_mmio_write,
+ /* TODO: MSIX should be LITTLE_ENDIAN. */
.endianness = DEVICE_NATIVE_ENDIAN,
.valid = {
.min_access_size = 4,
- [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 1/8] msix: Add simple BAR allocation MSIX setup functions, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 2/8] ivshmem: Convert to msix_init_exclusive_bar() interface, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 3/8] virtio: Convert to msix_init_exclusive_bar() interface, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 4/8] msix: Move msix_mmio_read, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item,
Alex Williamson <=
- [Qemu-devel] [PATCH v3 6/8] msix: Split PBA into it's own MemoryRegion, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 7/8] msix: Allow full specification of MSIX layout, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 8/8] msix: Switch msix_uninit to return void, Alex Williamson, 2012/06/14
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/14
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18