[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 8/8] msix: Switch msix_uninit to return void
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PATCH v3 8/8] msix: Switch msix_uninit to return void |
Date: |
Thu, 14 Jun 2012 12:16:57 -0600 |
User-agent: |
StGIT/0.14.3 |
It can't fail.
Signed-off-by: Alex Williamson <address@hidden>
---
hw/msix.c | 6 +++---
hw/msix.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index 15f8d7d..fd9ea95 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -328,10 +328,10 @@ static void msix_free_irq_entries(PCIDevice *dev)
}
/* Clean up resources for the device. */
-int msix_uninit(PCIDevice *dev, MemoryRegion *table_bar, MemoryRegion *pba_bar)
+void msix_uninit(PCIDevice *dev, MemoryRegion *table_bar, MemoryRegion
*pba_bar)
{
if (!msix_present(dev)) {
- return 0;
+ return;
}
pci_del_capability(dev, PCI_CAP_ID_MSIX, MSIX_CAP_LENGTH);
dev->msix_cap = 0;
@@ -348,7 +348,7 @@ int msix_uninit(PCIDevice *dev, MemoryRegion *table_bar,
MemoryRegion *pba_bar)
g_free(dev->msix_entry_used);
dev->msix_entry_used = NULL;
dev->cap_present &= ~QEMU_PCI_CAP_MSIX;
- return 0;
+ return;
}
void msix_uninit_exclusive_bar(PCIDevice *dev)
diff --git a/hw/msix.h b/hw/msix.h
index f637797..1786e27 100644
--- a/hw/msix.h
+++ b/hw/msix.h
@@ -13,8 +13,8 @@ int msix_init_exclusive_bar(PCIDevice *dev, unsigned short
nentries,
void msix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, int
len);
-int msix_uninit(PCIDevice *dev, MemoryRegion *table_bar,
- MemoryRegion *pba_bar);
+void msix_uninit(PCIDevice *dev, MemoryRegion *table_bar,
+ MemoryRegion *pba_bar);
void msix_uninit_exclusive_bar(PCIDevice *dev);
unsigned int msix_nr_vectors_allocated(const PCIDevice *dev);
- [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 1/8] msix: Add simple BAR allocation MSIX setup functions, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 2/8] ivshmem: Convert to msix_init_exclusive_bar() interface, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 3/8] virtio: Convert to msix_init_exclusive_bar() interface, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 4/8] msix: Move msix_mmio_read, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 6/8] msix: Split PBA into it's own MemoryRegion, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 7/8] msix: Allow full specification of MSIX layout, Alex Williamson, 2012/06/14
- [Qemu-devel] [PATCH v3 8/8] msix: Switch msix_uninit to return void,
Alex Williamson <=
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/14
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Jan Kiszka, 2012/06/18
- Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location, Michael S. Tsirkin, 2012/06/18