Re: [Qemu-devel] [PATCH v5 00/16] QEMU OpenRISC support

[Wei-Ren Chen]

On Thu, Jun 21, 2012 at 06:28:30PM +0100, Peter Maydell wrote:
> On 21 June 2012 18:24, Blue Swirl <address@hidden> wrote:
> > On Wed, Jun 20, 2012 at 7:10 AM, Jia Liu <address@hidden> wrote:
> >> ERROR: need consistent spacing around '*' (ctx:WxV)
> >> #99: FILE: target-openrisc/int_helper.c:53:
> >> +target_ulong HELPER(mul32)(CPUOpenRISCState *env,
> >>
> >> It is really weird. And, I don't know how to handle it.
> >
> > It's a limitation in checkpatch.pl, it is confused by any CPUxxxState
> > for some reason. Please just ignore these cases.
> 
> I think in this case it's more likely to be the HELPER() macro
> that is confusing it, but yes, just ignore the error.

  Should this be added to http://wiki.qemu.org/Contribute/SubmitAPatch
as an example? I remember someone else had the same problem before.

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj