Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

[Paolo Bonzini]

Il 03/07/2012 21:09, Blue Swirl ha scritto:
>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest 
>> > *req, uint8_t *outbuf)
>> >              outbuf[buflen++] = 0;   // not officially assigned
>> >              outbuf[buflen++] = 0;   // reserved
>> >              outbuf[buflen++] = id_len; // length of data following
>> > -
>> >              memcpy(outbuf+buflen, str, id_len);
>> >              buflen += id_len;
>> > +
>> > +            if (s->wwn) {
>> > +                outbuf[buflen++] = 0x1; // Binary
>> > +                outbuf[buflen++] = 0x3; // NAA
>> > +                outbuf[buflen++] = 0;   // reserved
> C99 comments.
> 

Just following the style of this code.  Feel free to send a patch to
replace with #defines.

Paolo