[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support |
|
Date: |
Fri, 20 Jul 2012 09:33:05 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120601 Thunderbird/10.0.5 |
Hi,
>> + /* FIXME: probably not the best idea to have this on the stack ... */
>> + u32 script[] = {
>
> Several places in the code DMA to the stack already (usb-ehci,
> usb-uhci, ata).
My concern isn't DMA'ing to the stack, but the size of the script and
possible stack overruns. But maybe it is a moot point with the stack
switching added to seabios recently.
cheers,
Gerd