[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH uq/master] kvm: i8254: Finish time conversion fi
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH uq/master] kvm: i8254: Finish time conversion fix |
Date: |
Tue, 14 Aug 2012 09:41:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-08-13 20:40, Michael Tokarev wrote:
> On 13.08.2012 22:18, Jan Kiszka wrote:
>> 0cdd3d1444 fixed reading back the counter load time from the kernel
>> while assuming the kernel would always update its load time on writing
>> the state. That is only true for channel 1, and so pit_get_channel_info
>> returned wrong output pin states for high counter values.
>>
>> Fix this by applying the offset also on kvm_pit_put. For this purpose,
>> we cache the clock offset in KVMPITState, only updating it on VM state
>> changes or when we write the state while the VM is stopped.
>
> Wug. The fix (consisting of two halves) appears to be quite messy.
I will split it up into offset caching and application to kvm_pit_put.
> Is it a (temporary) workaround or a real solution?
No, this is the real solution. It may look complex, but it is required
due to the different time bases of the in-kernel PIT and QEMU's vmclock.
We didn't care about this in qemu-kvm in the past, but upstream now
actually supports migration between in-kernel and user space models, and
it also supports the PC speaker with the in-kernel PIT enabled.
>
> And yes, this second half fixes the reported issue with grub timekeeping,
> and should fix the seabios problem as well (so it shouldn't be necessary
> to mess with timekeeping in seabios anymore).
Thanks, great to hear!
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, (continued)
Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Gleb Natapov, 2012/08/10
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Michael Tokarev, 2012/08/10
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Gleb Natapov, 2012/08/12
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Michael Tokarev, 2012/08/12
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Jan Kiszka, 2012/08/13
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Michael Tokarev, 2012/08/13
- Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip, Jan Kiszka, 2012/08/13
- [Qemu-devel] [PATCH uq/master] kvm: i8254: Finish time conversion fix, Jan Kiszka, 2012/08/13
- Re: [Qemu-devel] [PATCH uq/master] kvm: i8254: Finish time conversion fix, Michael Tokarev, 2012/08/13
- Re: [Qemu-devel] [PATCH uq/master] kvm: i8254: Finish time conversion fix,
Jan Kiszka <=