Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.

[Kevin Wolf]

Am 17.09.2012 17:22, schrieb Bharata B Rao:
> sockets: Make inet_parse() non static.
> 
> From: Bharata B Rao <address@hidden>
> 
> Make inet_parse() non-static so that other subsystems like gluster
> can use it to parse inet addresses. As a pre-requisite, define and
> globalize the qemu_inet_opts.
> 
> Signed-off-by: Bharata B Rao <address@hidden>
> ---
> 
>  Makefile.objs  |    2 +-
>  qemu-config.c  |   31 +++++++++++++++++++++++++++++++
>  qemu-sockets.c |   42 ++++++------------------------------------
>  qemu_socket.h  |    1 +
>  4 files changed, 39 insertions(+), 37 deletions(-)

Making the option list global sounds fine, but I don't think it should
be moved to qemu-config.c or added to vm_config_groups, which is
generally used for command line options and config file entries. At
least I can't imagine a command line option -inet would be very useful.

Kevin