[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static. |
|
Date: |
Tue, 18 Sep 2012 14:57:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
Il 18/09/2012 14:47, Kevin Wolf ha scritto:
>> > Makefile.objs | 2 +-
>> > qemu-config.c | 31 +++++++++++++++++++++++++++++++
>> > qemu-sockets.c | 42 ++++++------------------------------------
>> > qemu_socket.h | 1 +
>> > 4 files changed, 39 insertions(+), 37 deletions(-)
> Making the option list global sounds fine, but I don't think it should
> be moved to qemu-config.c or added to vm_config_groups, which is
> generally used for command line options and config file entries. At
> least I can't imagine a command line option -inet would be very useful.
Yes. Also, I'll send a pull-request for
http://patchwork.ozlabs.org/patch/180237/ soon, so you might as well
take that patch.
Paolo
[Qemu-devel] [PATCH v7 3/5] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count, Bharata B Rao, 2012/09/17
[Qemu-devel] [PATCH v7 4/5] configure: Add a config option for GlusterFS as block backend, Bharata B Rao, 2012/09/17
[Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend., Bharata B Rao, 2012/09/17