[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman |
Date: |
Fri, 21 Sep 2012 07:40:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7 |
On 09/20/12 17:33, Stefano Stabellini wrote:
> On Thu, 20 Sep 2012, Stefano Stabellini wrote:
>> On Thu, 20 Sep 2012, Gerd Hoffmann wrote:
>>> Hi,
>>>
>>>>> In any graphics mode relevant today vga emulation will use
>>>>> qemu_create_displaysurface_from(). Whenever a DisplayAllocator is
>>>>> present or not doesn't make any difference then.
>>>>
>>>> Unfortunately if my memory doesn't fail me, Windows uses 24 bpp.
>>>> So actually the DisplayAllocator interface is the one that is going to be
>>>> used all the time.
>>>
>>> Guess we want implement 24bpp support in displaylisteners then.
>>
>> vnc doesn't support 24bpp
>
> I mean the vnc protocol doesn't support 24bpp, so it couldn't help vnc
> (I am aware that at the moment vnc is not using a DisplayAllocator, but
> I guess it could in the future).
Yes, vnc should transform 24bpp into 32bpp. Given that vnc keeps a
shadow copy of the guest display _anyway_ (to figure which parts of the
guest display did _really_ change) we don't have to do any extra copying
work in vnc. We can just keep the shadow at 32bpp. The 'compare+copy'
code in vnc_refresh_server_surface must be able to cope with 24bpp guest
+ 32bpp server surface. Done. And we've dropped the 24->32 bpp
conversion in the vga emulation along the way.
cheers,
Gerd
- [Qemu-devel] [PATCH 1/9] QLIST-ify display change listeners., (continued)
- [Qemu-devel] [PATCH 1/9] QLIST-ify display change listeners., Gerd Hoffmann, 2012/09/19
- [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Gerd Hoffmann, 2012/09/19
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Stefano Stabellini, 2012/09/19
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Gerd Hoffmann, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Stefano Stabellini, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Gerd Hoffmann, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Stefano Stabellini, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Gerd Hoffmann, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Stefano Stabellini, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Stefano Stabellini, 2012/09/20
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman, Stefano Stabellini, 2012/09/21
[Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver., Gerd Hoffmann, 2012/09/19