Re: [Qemu-devel] [PATCH v4 2/4] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

[Orit Wasserman]

On 09/24/2012 12:07 PM, Paolo Bonzini wrote:
> Il 24/09/2012 11:53, Markus Armbruster ha scritto:
>> ongoing
>>
>>>> + * @errp: set in case of an error
>>>> + **/
>> We usually tack function comments to the function definition, not the
>> declaration.  Matter of taste.  I like it next to the definition,
>> because that improves the comment's chances to get updated along with
>> the function.
> 
> Not necessarily, see main-loop.h for example.
> 
> /me would like more of these...
too late :) 
> 
> Paolo
> 
>>>> +int inet_connect_opts(QemuOpts *opts, bool block, bool *in_progress,
>>>> +                      Error **errp);
>