Re: [Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set

[Paolo Bonzini]

Il 04/10/2012 20:06, Luiz Capitulino ha scritto:
>> > +    if (ret < 0 || local_err) {
>> > +        if (!local_err) {
>> > +            error_set_errno(errp, -ret, QERR_UNDEFINED_ERROR);
> Two problems here. First, ret usually is not -errno. If we really want to
> use it here (I think this is great improvement) than we have to fix the
> functions called by qmp_migrate() first.

Yes, it is only -errno for migration-unix.c, but anyway...

> The other problem is just this will produce a weird error message, it's
> better to do s/QERR_UNDEFINED_ERROR/"migration has failed".
> 

... both problems are fixed later in the series when ret is eliminated.

Paolo