[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 16/17] target-i386: cpu: separate cpudef lookup from
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 16/17] target-i386: cpu: separate cpudef lookup from feature string parsing |
Date: |
Mon, 12 Nov 2012 19:39:01 -0200 |
- Move the CPU string split and cpudef lookup to cpu_x86_init();
- Rename cpu_x86_find_by_name() to cpu_x86_parse_feature_string(),
and make it just get the feature string as input.
This will allow us to use the CPU model name for the CPU class lookup,
inside cpu_x86_init().
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/cpu.c | 40 +++++++++++++++++++---------------------
1 file changed, 19 insertions(+), 21 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 9b8e480..e47ec5d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1173,15 +1173,11 @@ error:
return -1;
}
-static int cpu_x86_find_by_name(X86CPUDefinition *x86_cpu_def,
- const char *cpu_model, Error **errp)
+static int cpu_x86_parse_featurestr(X86CPUDefinition *x86_cpu_def,
+ char *features, Error **errp)
{
unsigned int i;
- X86CPUDefinition *def;
- char *name; /* CPU model name */
- char *features; /* Full feature "key=value,..." string */
char *featurestr; /* Single 'key=value" string being parsed */
- gchar **model_pieces; /* array after split of name,features */
/* Features to be added*/
uint32_t plus_features = 0, plus_ext_features = 0;
uint32_t plus_ext2_features = 0, plus_ext3_features = 0;
@@ -1194,18 +1190,6 @@ static int cpu_x86_find_by_name(X86CPUDefinition
*x86_cpu_def,
uint32_t minus_7_0_ebx_features = 0;
uint32_t numvalue;
- model_pieces = g_strsplit(cpu_model, ",", 2);
- if (!model_pieces[0]) {
- goto error;
- }
-
- name = model_pieces[0];
- features = model_pieces[1];
-
- if (cpu_x86_find_cpudef(name, x86_cpu_def, errp) < 0) {
- goto error;
- }
-
add_flagname_to_bitmaps("hypervisor", &plus_features,
&plus_ext_features, &plus_ext2_features, &plus_ext3_features,
&plus_kvm_features, &plus_svm_features, &plus_7_0_ebx_features);
@@ -1344,11 +1328,9 @@ static int cpu_x86_find_by_name(X86CPUDefinition
*x86_cpu_def,
if (x86_cpu_def->cpuid_7_0_ebx_features && x86_cpu_def->level < 7) {
x86_cpu_def->level = 7;
}
- g_strfreev(model_pieces);
return 0;
error:
- g_strfreev(model_pieces);
if (!error_is_set(errp)) {
error_set(errp, QERR_INVALID_PARAMETER_COMBINATION);
}
@@ -1527,6 +1509,8 @@ X86CPU *cpu_x86_init(const char *cpu_string)
CPUX86State *env;
Error *error = NULL;
X86CPUDefinition def;
+ char *name, *features;
+ gchar **model_pieces;
cpu = X86_CPU(object_new(TYPE_X86_CPU));
env = &cpu->env;
@@ -1534,7 +1518,18 @@ X86CPU *cpu_x86_init(const char *cpu_string)
memset(&def, 0, sizeof(def));
- if (cpu_x86_find_by_name(&def, cpu_string, &error) < 0) {
+ model_pieces = g_strsplit(cpu_string, ",", 2);
+ if (!model_pieces[0]) {
+ goto error;
+ }
+ name = model_pieces[0];
+ features = model_pieces[1];
+
+ if (cpu_x86_find_cpudef(name, &def, &error) < 0) {
+ goto error;
+ }
+
+ if (cpu_x86_parse_featurestr(&def, features, &error) < 0) {
goto error;
}
@@ -1546,8 +1541,11 @@ X86CPU *cpu_x86_init(const char *cpu_string)
if (error) {
goto error;
}
+
+ g_strfreev(model_pieces);
return cpu;
error:
+ g_strfreev(model_pieces);
object_delete(OBJECT(cpu));
if (error) {
error_report("cpu_x86_init: %s", error_get_pretty(error));
--
1.7.11.7
- Re: [Qemu-devel] [PATCH 09/17] target-i386: move out CPU features initialization to separate func, (continued)
- [Qemu-devel] [PATCH 10/17] target-i386: kill cpu_x86_register(), Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 12/17] target-i386: cpu_x86_find_by_name(): split CPU model and feature string first, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 14/17] target-i386: cpu_x86_init(): rename cpu_model to cpu_string, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 08/17] target-i386: cpu_x86_register(): reorder CPU property setting, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 15/17] target-i386: cpu_x86_init(): eliminate extra 'def1' variable, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 11/17] target-i386: return Error from cpu_x86_find_by_name(), Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 07/17] target-i386: cpu_x86_register(): report errors using Error parameter, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 13/17] target-i386: cpu: create cpu_x86_find_cpudef() function, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 17/17] target-i386: cpu_x86_init(): reorder split of CPU string and creation of CPU object, Eduardo Habkost, 2012/11/12
- [Qemu-devel] [PATCH 16/17] target-i386: cpu: separate cpudef lookup from feature string parsing,
Eduardo Habkost <=