|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman |
Date: | Fri, 16 Nov 2012 18:53:44 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 |
δΊ 2012-11-16 18:38, Gerd Hoffmann ει:
On 11/16/12 11:26, Peter Maydell wrote:On 16 November 2012 10:23, Paolo Bonzini <address@hidden> wrote:Il 16/11/2012 10:27, Peter Maydell ha scritto:On 16 November 2012 05:05, Wenchao Xia <address@hidden> wrote:- test -f pixman/config.log && make -C pixman distclean + @if test -f pixman/config.log; \ + then \ + make -C pixman distclean;\ + fiThese two bits of shellscript both do the same thing, don't they?No, when "test" fails the && exits with a failure. The "if" exits with a success (not the most portable thing ever, but we assume a decent shell elsewhere).Aha. I love shell. (This detail could usefully have been provided in the commit message...)Agree. Can I get a version with an updated commit message for the pixman patch queue? thanks, Gerd
Sure,I'll resend according to more comments later. -- Best Regards Wenchao Xia
[Prev in Thread] | Current Thread | [Next in Thread] |