[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] inet_parse: fix ,to= parsing
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] inet_parse: fix ,to= parsing |
Date: |
Thu, 22 Nov 2012 09:29:31 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Stefano Stabellini <address@hidden> writes:
> Fix inet_parse to parse the ",to=" command line option correctly.
>
> Signed-off-by: Stefano Stabellini <address@hidden>
>
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index cfed9c5..f8740dd 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -529,8 +529,9 @@ static InetSocketAddress *inet_parse(const char *str,
> Error **errp)
> optstr = str + pos;
> h = strstr(optstr, ",to=");
> if (h) {
> - if (1 != sscanf(str, "%d%n", &to, &pos) ||
> - (str[pos] != '\0' && str[pos] != ',')) {
> + h += 4;
> + if (1 != sscanf(h, "%d%n", &to, &pos) ||
> + (h[pos] != '\0' && h[pos] != ',')) {
> error_setg(errp, "error parsing to= argument");
> goto fail;
> }
Similar patch just got committed as 1ccbc285. Thanks anyway!