Re: [Qemu-devel] [PATCH v7 2/2] qemu-ga: sample fsfreeze hooks

[Eric Blake]

On 12/07/2012 06:55 AM, Luiz Capitulino wrote:
> On Fri, 07 Dec 2012 17:39:32 +0900
> Tomoki Sekiyama <address@hidden> wrote:
> 
>> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
>>   - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
>>   - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot
>>
>> Signed-off-by: Tomoki Sekiyama <address@hidden>
>> ---
>>  .gitignore                                         |    1 
>>  Makefile                                           |    2 -
>>  scripts/qemu-guest-agent/fsfreeze-hook             |   33 ++++++++++++
>>  .../fsfreeze-hook.d/mysql-flush.sh.sample          |   55 
>> ++++++++++++++++++++
>>  4 files changed, 90 insertions(+), 1 deletion(-)
>>  create mode 100755 scripts/qemu-guest-agent/fsfreeze-hook
>>  create mode 100755 
>> scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample
>>
>> diff --git a/.gitignore b/.gitignore
>> index bd6ba1c..286822d 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -93,3 +93,4 @@ cscope.*
>>  tags
>>  TAGS
>>  *~
>> +!scripts/qemu-guest-agent/fsfreeze-hook.d
> 
> Why? Do we expect to have *~ files in there?

What does your question have to do with the patch, which isn't even
touching the pre-existing *~ line?

> 
>> diff --git a/Makefile b/Makefile
>> index 9ecbcbb..466dcd7 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -248,7 +248,7 @@ clean:
>>  # avoid old build problems by removing potentially incorrect old files
>>      rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h 
>> gen-op-arm.h
>>      rm -f qemu-options.def
>> -    find . -name '*.[od]' -exec rm -f {} +
>> +    find . -name '*.[od]' -type f -exec rm -f {} +
> 
> What does this change have to do with this patch?

Because this patch introduces a directory
scripts/qemu-guest-agent/fsfreeze-hook.d/mysql-flush.sh.sample that
belongs to the repo and therefore must not be cleaned.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature