[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking |
Date: |
Mon, 17 Dec 2012 15:51:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
On 12/17/12 15:47, Hans de Goede wrote:
> Hi,
>
> On 12/17/2012 03:39 PM, Gerd Hoffmann wrote:
>> On 12/17/12 15:23, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 12/17/2012 02:16 PM, Gerd Hoffmann wrote:
>>>> On 12/14/12 14:35, Hans de Goede wrote:
>>>>> Note that a shadow variable is used instead of changing frindex to
>>>>> uframe accuracy because we must send a frindex which is a multiple
>>>>> of 8
>>>>> during migration for migration compatibility, and rounding it down to
>>>>> a multiple of 8 pre-migration, can lead to frindex going backwards
>>>>> from
>>>>> the guest pov.
>>>>
>>>> Jumping forward instead?
>>>
>>> You mean rounding the send frindex up pre-migration, I didn't really
>>> consider
>>> that as it will cause us skipping processing an entry in the periodic
>>> frame
>>> list. I guess doing that on migration isn't too bad. OTOH giving the
>>> guest
>>> only frame accuracy like we've been doing till now also works fine...
>>>
>>> Your choice :)
>>
>> I'm looking for a way to avoid the shadow variable, but of course
>> without breaking migration. giving the guest only frame accuracy looks
>> good to me.
>
> Ok, but then we need the shadow variable, iow then the patch stays as is
> ...
Can't we (a) switch frindex to microframe resolution, (b) round to frame
resolution in pre_save and (c) return frindex & ~7 on guest register reads?
cheers,
Gerd
- [Qemu-devel] [PATCH 05/26] ehci: writeback_async_complete_packet: verify qh and qtd, (continued)
- [Qemu-devel] [PATCH 05/26] ehci: writeback_async_complete_packet: verify qh and qtd, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 06/26] ehci: Verify qtd for async completed packets, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 04/26] ehci: Move get / put_dwords upwards, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 08/26] ehci: Verify a queue's ep direction does not change, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 07/26] ehci: Add an ehci_get_pid helper function, Hans de Goede, 2012/12/14
- [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Hans de Goede, 2012/12/14
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Gerd Hoffmann, 2012/12/17
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Hans de Goede, 2012/12/17
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Gerd Hoffmann, 2012/12/17
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Hans de Goede, 2012/12/17
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Hans de Goede, 2012/12/18
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Gerd Hoffmann, 2012/12/18
- Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking, Hans de Goede, 2012/12/18
[Qemu-devel] [PATCH 12/26] uhci: Fix 1 ms delay in interrupt reporting to the guest, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 10/26] ehci: Further speedup rescanning if async schedule after raising an interrupt, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 11/26] ehci: Don't call commit_irq after raising PCD, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 13/26] uhci: Fix pending interrupts getting lost on migration, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 14/26] uhci: Add a QH_VALID define, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 17/26] hid: Change idle handling to use a timer, Hans de Goede, 2012/12/14
[Qemu-devel] [PATCH 15/26] uhci: Limit amount of frames processed in one go, Hans de Goede, 2012/12/14