Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

[KONRAD Frédéric]

On 02/01/2013 15:16, Andreas Färber wrote:
> Am 02.01.2013 15:08, schrieb Anthony Liguori:
> > address@hidden writes:
> >
> > > From: KONRAD Frederic <address@hidden>
> > >
> > > Add a max_dev field to BusState to specify the maximum amount of devices allowed
> > > on the bus ( have no effect if max_dev=0 )
> > >
> > > Signed-off-by: KONRAD Frederic <address@hidden>
> > > ---
> > >   hw/qdev-core.h    |  2 ++
> > >   hw/qdev-monitor.c | 11 +++++++++++
> > >   2 files changed, 13 insertions(+)
> > >
> > > diff --git a/hw/qdev-core.h b/hw/qdev-core.h
> > > index d672cca..af909b9 100644
> > > --- a/hw/qdev-core.h
> > > +++ b/hw/qdev-core.h
> > > @@ -104,6 +104,8 @@ struct BusState {
> > >       const char *name;
> > >       int allow_hotplug;
> > >       int max_index;
> > > +    /* maximum devices allowed on the bus, 0 : no limit. */
> > > +    int max_dev;
> Can't for the virtio-bus case (which this is for AFAIU) the same effect
> be achieved by setting max_index? If not, this could use some more
> documentation - btw using gtk-doc style comments (above struct) would be
> a bonus.
no, max_index is just a variable which count the number of bus children 
I think.
max_index is incremented each time bus_add_child is called.

maybe the name max_index is not a good choice ?

> Regards,
> Andreas
>
> P.S. Please remember to use English punctuation rules, i.e. no spaces
> before colon or inside parenthesis. ;)
:s sorry for that.

>