qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowe


From: KONRAD Frédéric
Subject: Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.
Date: Thu, 03 Jan 2013 15:03:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 02/01/2013 15:08, Anthony Liguori wrote:
address@hidden writes:

From: KONRAD Frederic <address@hidden>

Add a max_dev field to BusState to specify the maximum amount of devices allowed
on the bus ( have no effect if max_dev=0 )

Signed-off-by: KONRAD Frederic <address@hidden>
---
  hw/qdev-core.h    |  2 ++
  hw/qdev-monitor.c | 11 +++++++++++
  2 files changed, 13 insertions(+)

diff --git a/hw/qdev-core.h b/hw/qdev-core.h
index d672cca..af909b9 100644
--- a/hw/qdev-core.h
+++ b/hw/qdev-core.h
@@ -104,6 +104,8 @@ struct BusState {
      const char *name;
      int allow_hotplug;
      int max_index;
+    /* maximum devices allowed on the bus, 0 : no limit. */
+    int max_dev;
      QTAILQ_HEAD(ChildrenHead, BusChild) children;
      QLIST_ENTRY(BusState) sibling;
  };
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index a1b4d6a..7a9d275 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -292,6 +292,17 @@ static BusState *qbus_find_recursive(BusState *bus, const 
char *name,
      if (bus_typename && !object_dynamic_cast(OBJECT(bus), bus_typename)) {
          match = 0;
      }
+    if ((bus->max_dev != 0) && (bus->max_dev <= bus->max_index)) {
+        if (name != NULL) {
+            /* bus was explicitly specified : return an error. */
+            qerror_report(ERROR_CLASS_GENERIC_ERROR, "Bus '%s' is full",
+                          bus->name);
+            return NULL;
+        } else {
+            /* bus was not specified : try to find another one. */
+            match = 0;
+        }
+    }
      if (match) {
          return bus;
      }
Nice change, but I wonder if this should be a class property instead of
an object property?  Would different objects of the same class ever set
this differently?
I don't know. What do you think is the best ?

Fred


Regards,

Anthony Liguori

--
1.7.11.7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]